net: hns3: make sure ptp clock is unregister and freed if hclge_ptp_get_cycle returns an error

Peiyang Wang · Paolo Abeni · commit b7365eab3983 · 2025-03-04T12:50:59.000+01:00
During the initialization of ptp, hclge_ptp_get_cycle might return an error and returned directly without unregister clock and free it. To avoid that, call hclge_ptp_destroy_clock to unregist and free clock if hclge_ptp_get_cycle failed. Fixes: 8373cd3 ("net: hns3: change the method of obtaining default ptp cycle") Signed-off-by: Peiyang Wang <wangpeiyang1@huawei.com> Signed-off-by: Jijie Shao <shaojijie@huawei.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20250228105258.1243461-1-shaojijie@huawei.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.c
@@ -483,7 +483,7 @@ int hclge_ptp_init(struct hclge_dev *hdev)
 
 		ret = hclge_ptp_get_cycle(hdev);
 		if (ret)
-			return ret;
+			goto out;
 	}
 
 	ret = hclge_ptp_int_en(hdev, true);

Original file line number	Diff line number	Diff line change
`@@ -483,7 +483,7 @@ int hclge_ptp_init(struct hclge_dev *hdev)`
`483`	`483`
`484`	`484`	`ret = hclge_ptp_get_cycle(hdev);`
`485`	`485`	`if (ret)`
`486`		`- return ret;`
	`486`	`+ goto out;`
`487`	`487`	`}`
`488`	`488`
`489`	`489`	`ret = hclge_ptp_int_en(hdev, true);`