Skip to content

Commit b6b3624

Browse files
z00467499Steve French
authored andcommitted
cifs: Use help macro to get the mid header size
It's better to use MID_HEADER_SIZE because the unfolded expression too long. No actual functional changes, minor readability improvement. Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com> Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent 9789de8 commit b6b3624

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

fs/cifs/cifsglob.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -558,6 +558,7 @@ struct smb_version_values {
558558
#define HEADER_SIZE(server) (server->vals->header_size)
559559
#define MAX_HEADER_SIZE(server) (server->vals->max_header_size)
560560
#define HEADER_PREAMBLE_SIZE(server) (server->vals->header_preamble_size)
561+
#define MID_HEADER_SIZE(server) (HEADER_SIZE(server) - 1 - HEADER_PREAMBLE_SIZE(server))
561562

562563
/**
563564
* CIFS superblock mount flags (mnt_cifs_flags) to consider when

fs/cifs/connect.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1065,8 +1065,7 @@ standard_receive3(struct TCP_Server_Info *server, struct mid_q_entry *mid)
10651065

10661066
/* now read the rest */
10671067
length = cifs_read_from_socket(server, buf + HEADER_SIZE(server) - 1,
1068-
pdu_length - HEADER_SIZE(server) + 1 +
1069-
HEADER_PREAMBLE_SIZE(server));
1068+
pdu_length - MID_HEADER_SIZE(server));
10701069

10711070
if (length < 0)
10721071
return length;
@@ -1198,8 +1197,7 @@ cifs_demultiplex_thread(void *p)
11981197
server->pdu_size = pdu_length;
11991198

12001199
/* make sure we have enough to get to the MID */
1201-
if (server->pdu_size < HEADER_SIZE(server) - 1 -
1202-
HEADER_PREAMBLE_SIZE(server)) {
1200+
if (server->pdu_size < MID_HEADER_SIZE(server)) {
12031201
cifs_server_dbg(VFS, "SMB response too short (%u bytes)\n",
12041202
server->pdu_size);
12051203
cifs_reconnect(server, true);
@@ -1209,8 +1207,7 @@ cifs_demultiplex_thread(void *p)
12091207
/* read down to the MID */
12101208
length = cifs_read_from_socket(server,
12111209
buf + HEADER_PREAMBLE_SIZE(server),
1212-
HEADER_SIZE(server) - 1 -
1213-
HEADER_PREAMBLE_SIZE(server));
1210+
MID_HEADER_SIZE(server));
12141211
if (length < 0)
12151212
continue;
12161213
server->total_read += length;

0 commit comments

Comments
 (0)