Skip to content

Commit b6a7bac

Browse files
jhovoldgregkh
authored andcommitted
serial: qcom-geni: drop bogus uart_write_wakeup()
Drop the bogus uart_write_wakeup() from when setting up a new DMA transfer, which does not free up any more space in the ring buffer. Any pending writers will be woken up when the transfer completes. Cc: stable <stable@kernel.org> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Reviewed-by: Andrew Halaney <ahalaney@redhat.com> Tested-by: Andrew Halaney <ahalaney@redhat.com> # sa8540p-ride Link: https://lore.kernel.org/r/20230307164405.14218-5-johan+linaro@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 9782078 commit b6a7bac

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

drivers/tty/serial/qcom_geni_serial.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -634,10 +634,6 @@ static void qcom_geni_serial_start_tx_dma(struct uart_port *uport)
634634
if (uart_circ_empty(xmit))
635635
return;
636636

637-
xmit_size = uart_circ_chars_pending(xmit);
638-
if (xmit_size < WAKEUP_CHARS)
639-
uart_write_wakeup(uport);
640-
641637
xmit_size = CIRC_CNT_TO_END(xmit->head, xmit->tail, UART_XMIT_SIZE);
642638

643639
qcom_geni_serial_setup_tx(uport, xmit_size);

0 commit comments

Comments
 (0)