Skip to content

Commit b662b16

Browse files
flynnjiangrodrigovivi
authored andcommitted
drm: Fix potential overflow issue in event_string array
When calling scnprintf() to append recovery method to event_string, the second argument should be `sizeof(event_string) - len`, otherwise there is a potential overflow problem. Fixes: b7cf9f4 ("drm: Introduce device wedged event") Signed-off-by: Feng Jiang <jiangfeng@kylinos.cn> Reviewed-by: André Almeida <andrealmeid@igalia.com> Reviewed-by: Raag Jadav <raag.jadav@intel.com> Link: https://lore.kernel.org/r/20250409014633.31303-1-jiangfeng@kylinos.cn Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent 75680b7 commit b662b16

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/drm_drv.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,7 @@ int drm_dev_wedged_event(struct drm_device *dev, unsigned long method)
549549
if (drm_WARN_ONCE(dev, !recovery, "invalid recovery method %u\n", opt))
550550
break;
551551

552-
len += scnprintf(event_string + len, sizeof(event_string), "%s,", recovery);
552+
len += scnprintf(event_string + len, sizeof(event_string) - len, "%s,", recovery);
553553
}
554554

555555
if (recovery)

0 commit comments

Comments
 (0)