Skip to content

Commit b642e08

Browse files
Yang Likwilczynski
authored andcommitted
PCI: xilinx-xdma: Remove redundant dev_err()
There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. ./drivers/pci/controller/pcie-xilinx-dma-pl.c:688:2-9: line 688 is redundant because platform_get_irq() already prints an error ./drivers/pci/controller/pcie-xilinx-dma-pl.c:702:2-9: line 702 is redundant because platform_get_irq() already prints an error Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7074 Link: https://lore.kernel.org/linux-pci/20231030061242.51475-1-yang.lee@linux.alibaba.com Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
1 parent b85ea95 commit b642e08

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

drivers/pci/controller/pcie-xilinx-dma-pl.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -684,10 +684,8 @@ static int xilinx_request_msi_irq(struct pl_dma_pcie *port)
684684
int ret;
685685

686686
port->msi.irq_msi0 = platform_get_irq_byname(pdev, "msi0");
687-
if (port->msi.irq_msi0 <= 0) {
688-
dev_err(dev, "Unable to find msi0 IRQ line\n");
687+
if (port->msi.irq_msi0 <= 0)
689688
return port->msi.irq_msi0;
690-
}
691689

692690
ret = devm_request_irq(dev, port->msi.irq_msi0, xilinx_pl_dma_pcie_msi_handler_low,
693691
IRQF_SHARED | IRQF_NO_THREAD, "xlnx-pcie-dma-pl",
@@ -698,10 +696,8 @@ static int xilinx_request_msi_irq(struct pl_dma_pcie *port)
698696
}
699697

700698
port->msi.irq_msi1 = platform_get_irq_byname(pdev, "msi1");
701-
if (port->msi.irq_msi1 <= 0) {
702-
dev_err(dev, "Unable to find msi1 IRQ line\n");
699+
if (port->msi.irq_msi1 <= 0)
703700
return port->msi.irq_msi1;
704-
}
705701

706702
ret = devm_request_irq(dev, port->msi.irq_msi1, xilinx_pl_dma_pcie_msi_handler_high,
707703
IRQF_SHARED | IRQF_NO_THREAD, "xlnx-pcie-dma-pl",

0 commit comments

Comments
 (0)