Skip to content

Commit b5cab28

Browse files
committed
Merge tag 'fbdev-for-6.5-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev
Pull fbdev fixes and cleanups from Helge Deller: - various code cleanups in amifb, atmel_lcdfb, ssd1307fb, kyro and goldfishfb * tag 'fbdev-for-6.5-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev: fbdev: goldfishfb: Do not check 0 for platform_get_irq() fbdev: atmel_lcdfb: Remove redundant of_match_ptr() fbdev: kyro: Remove unused declarations fbdev: ssd1307fb: Print the PWM's label instead of its number fbdev: mmp: fix value check in mmphw_probe() fbdev: amifb: Replace zero-length arrays with DECLARE_FLEX_ARRAY() helper
2 parents 2383ffc + 0650d50 commit b5cab28

File tree

6 files changed

+9
-19
lines changed

6 files changed

+9
-19
lines changed

drivers/video/fbdev/amifb.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,7 @@ struct fb_var_cursorinfo {
687687
__u16 height;
688688
__u16 xspot;
689689
__u16 yspot;
690-
__u8 data[1]; /* field with [height][width] */
690+
DECLARE_FLEX_ARRAY(__u8, data); /* field with [height][width] */
691691
};
692692

693693
struct fb_cursorstate {

drivers/video/fbdev/atmel_lcdfb.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1308,7 +1308,7 @@ static struct platform_driver atmel_lcdfb_driver = {
13081308
.resume = atmel_lcdfb_resume,
13091309
.driver = {
13101310
.name = "atmel_lcdfb",
1311-
.of_match_table = of_match_ptr(atmel_lcdfb_dt_ids),
1311+
.of_match_table = atmel_lcdfb_dt_ids,
13121312
},
13131313
};
13141314

drivers/video/fbdev/goldfishfb.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,8 @@ static int goldfish_fb_probe(struct platform_device *pdev)
203203
}
204204

205205
fb->irq = platform_get_irq(pdev, 0);
206-
if (fb->irq <= 0) {
207-
ret = -ENODEV;
206+
if (fb->irq < 0) {
207+
ret = fb->irq;
208208
goto err_no_irq;
209209
}
210210

drivers/video/fbdev/mmp/hw/mmp_ctrl.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,9 @@ static int mmphw_probe(struct platform_device *pdev)
519519
"unable to get clk %s\n", mi->clk_name);
520520
goto failed;
521521
}
522-
clk_prepare_enable(ctrl->clk);
522+
ret = clk_prepare_enable(ctrl->clk);
523+
if (ret)
524+
goto failed;
523525

524526
/* init global regs */
525527
ctrl_set_default(ctrl);

drivers/video/fbdev/ssd1307fb.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -399,8 +399,8 @@ static int ssd1307fb_init(struct ssd1307fb_par *par)
399399
/* Enable the PWM */
400400
pwm_enable(par->pwm);
401401

402-
dev_dbg(&par->client->dev, "Using PWM%d with a %lluns period.\n",
403-
par->pwm->pwm, pwm_get_period(par->pwm));
402+
dev_dbg(&par->client->dev, "Using PWM %s with a %lluns period.\n",
403+
par->pwm->label, pwm_get_period(par->pwm));
404404
}
405405

406406
/* Set initial contrast */

include/video/kyro.h

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -38,18 +38,6 @@ struct kyrofb_info {
3838
int wc_cookie;
3939
};
4040

41-
extern int kyro_dev_init(void);
42-
extern void kyro_dev_reset(void);
43-
44-
extern unsigned char *kyro_dev_physical_fb_ptr(void);
45-
extern unsigned char *kyro_dev_virtual_fb_ptr(void);
46-
extern void *kyro_dev_physical_regs_ptr(void);
47-
extern void *kyro_dev_virtual_regs_ptr(void);
48-
extern unsigned int kyro_dev_fb_size(void);
49-
extern unsigned int kyro_dev_regs_size(void);
50-
51-
extern u32 kyro_dev_overlay_offset(void);
52-
5341
/*
5442
* benedict.gaster@superh.com
5543
* Added the follow IOCTLS for the creation of overlay services...

0 commit comments

Comments
 (0)