Skip to content

Commit b4a48c5

Browse files
Uwe Kleine-Königrafaeljw
authored andcommitted
ACPI: pfr_telemetry: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 24fd13c commit b4a48c5

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/acpi/pfr_telemetry.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -347,13 +347,11 @@ static const struct file_operations acpi_pfrt_log_fops = {
347347
.llseek = noop_llseek,
348348
};
349349

350-
static int acpi_pfrt_log_remove(struct platform_device *pdev)
350+
static void acpi_pfrt_log_remove(struct platform_device *pdev)
351351
{
352352
struct pfrt_log_device *pfrt_log_dev = platform_get_drvdata(pdev);
353353

354354
misc_deregister(&pfrt_log_dev->miscdev);
355-
356-
return 0;
357355
}
358356

359357
static void pfrt_log_put_idx(void *data)
@@ -427,7 +425,7 @@ static struct platform_driver acpi_pfrt_log_driver = {
427425
.acpi_match_table = acpi_pfrt_log_ids,
428426
},
429427
.probe = acpi_pfrt_log_probe,
430-
.remove = acpi_pfrt_log_remove,
428+
.remove_new = acpi_pfrt_log_remove,
431429
};
432430
module_platform_driver(acpi_pfrt_log_driver);
433431

0 commit comments

Comments
 (0)