Skip to content

Commit b42b6f4

Browse files
Chaitanya KulkarniChristoph Hellwig
authored andcommitted
nvme: don't print verbose errors for internal passthrough requests
Use the RQF_QUIET flag to skip the newly added verbose error reporting, and set the flag in __nvme_submit_sync_cmd, which is used for most internal passthrough requests where we do expect errors (e.g. due to probing for optional functionality). This is similar to what the SCSI verbose error logging does. Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com> Reviewed-by: Alan Adamson <alan.adamson@oracle.com> Reviewed-by: Keith Busch <kbusch@kernel.org> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> Tested-by: Alan Adamson <alan.adamson@oracle.com> Tested-by: Yi Zhang <yi.zhang@redhat.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
1 parent 3e3876d commit b42b6f4

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/nvme/host/core.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ static inline void nvme_end_req(struct request *req)
366366
{
367367
blk_status_t status = nvme_error_status(nvme_req(req)->status);
368368

369-
if (unlikely(nvme_req(req)->status != NVME_SC_SUCCESS))
369+
if (unlikely(nvme_req(req)->status && !(req->rq_flags & RQF_QUIET)))
370370
nvme_log_error(req);
371371
nvme_end_req_zoned(req);
372372
nvme_trace_bio_complete(req);
@@ -1015,6 +1015,7 @@ int __nvme_submit_sync_cmd(struct request_queue *q, struct nvme_command *cmd,
10151015
goto out;
10161016
}
10171017

1018+
req->rq_flags |= RQF_QUIET;
10181019
ret = nvme_execute_rq(req, at_head);
10191020
if (result && ret >= 0)
10201021
*result = nvme_req(req)->result;

0 commit comments

Comments
 (0)