Skip to content

Commit b32283d

Browse files
harshimogalapallimartinkpetersen
authored andcommitted
scsi: scsi_debug: Fix missing error code in scsi_debug_init()
Smatch reports: drivers/scsi/scsi_debug.c:6996 scsi_debug_init() warn: missing error code 'ret' Although it is unlikely that KMEM_CACHE might fail, but if it does then ret might be zero. So to fix this explicitly mark ret as "-ENOMEM" and then goto driver_unreg. Fixes: 1107c7b ("scsi: scsi_debug: Dynamically allocate sdebug_queued_cmd") Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Link: https://lore.kernel.org/r/20230406074607.3637097-1-harshit.m.mogalapalli@oracle.com Reviewed-by: John Garry <john.g.garry@oracle.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent e01e229 commit b32283d

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/scsi/scsi_debug.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6992,8 +6992,10 @@ static int __init scsi_debug_init(void)
69926992
sdebug_add_host = 0;
69936993

69946994
queued_cmd_cache = KMEM_CACHE(sdebug_queued_cmd, SLAB_HWCACHE_ALIGN);
6995-
if (!queued_cmd_cache)
6995+
if (!queued_cmd_cache) {
6996+
ret = -ENOMEM;
69966997
goto driver_unreg;
6998+
}
69976999

69987000
for (k = 0; k < hosts_to_add; k++) {
69997001
if (want_store && k == 0) {

0 commit comments

Comments
 (0)