Skip to content

Commit b313eb9

Browse files
author
Trond Myklebust
committed
NFS: Improve O_DIRECT tracing
Switch the formatting to match the other NFS tracepoints. Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
1 parent af887e4 commit b313eb9

File tree

1 file changed

+9
-12
lines changed

1 file changed

+9
-12
lines changed

fs/nfs/nfstrace.h

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1597,12 +1597,10 @@ DECLARE_EVENT_CLASS(nfs_direct_req_class,
15971597
TP_ARGS(dreq),
15981598

15991599
TP_STRUCT__entry(
1600-
__field(const struct nfs_direct_req *, dreq)
16011600
__field(dev_t, dev)
16021601
__field(u64, fileid)
16031602
__field(u32, fhandle)
1604-
__field(int, ref)
1605-
__field(loff_t, io_start)
1603+
__field(loff_t, offset)
16061604
__field(ssize_t, count)
16071605
__field(ssize_t, bytes_left)
16081606
__field(ssize_t, error)
@@ -1614,26 +1612,25 @@ DECLARE_EVENT_CLASS(nfs_direct_req_class,
16141612
const struct nfs_inode *nfsi = NFS_I(inode);
16151613
const struct nfs_fh *fh = &nfsi->fh;
16161614

1617-
__entry->dreq = dreq;
16181615
__entry->dev = inode->i_sb->s_dev;
16191616
__entry->fileid = nfsi->fileid;
16201617
__entry->fhandle = nfs_fhandle_hash(fh);
1621-
__entry->ref = kref_read(&dreq->kref);
1622-
__entry->io_start = dreq->io_start;
1618+
__entry->offset = dreq->io_start;
16231619
__entry->count = dreq->count;
16241620
__entry->bytes_left = dreq->bytes_left;
16251621
__entry->error = dreq->error;
16261622
__entry->flags = dreq->flags;
16271623
),
16281624

16291625
TP_printk(
1630-
"dreq=%p fileid=%02x:%02x:%llu fhandle=0x%08x ref=%d "
1631-
"io_start=%lld count=%zd bytes_left=%zd error=%zd flags=%s",
1632-
__entry->dreq, MAJOR(__entry->dev), MINOR(__entry->dev),
1626+
"error=%zd fileid=%02x:%02x:%llu fhandle=0x%08x "
1627+
"offset=%lld count=%zd bytes_left=%zd flags=%s",
1628+
__entry->error, MAJOR(__entry->dev),
1629+
MINOR(__entry->dev),
16331630
(unsigned long long)__entry->fileid,
1634-
__entry->fhandle, __entry->ref,
1635-
__entry->io_start, __entry->count, __entry->bytes_left,
1636-
__entry->error, nfs_show_direct_req_flags(__entry->flags)
1631+
__entry->fhandle, __entry->offset,
1632+
__entry->count, __entry->bytes_left,
1633+
nfs_show_direct_req_flags(__entry->flags)
16371634
)
16381635
);
16391636

0 commit comments

Comments
 (0)