Skip to content

Commit b2ef51c

Browse files
Haoxiang Liakpm00
authored andcommitted
rapidio: fix an API misues when rio_add_net() fails
rio_add_net() calls device_register() and fails when device_register() fails. Thus, put_device() should be used rather than kfree(). Add "mport->net = NULL;" to avoid a use after free issue. Link: https://lkml.kernel.org/r/20250227073409.3696854-1-haoxiang_li2024@163.com Fixes: e8de370 ("rapidio: add mport char device driver") Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> Cc: Alexandre Bounine <alex.bou9@gmail.com> Cc: Matt Porter <mporter@kernel.crashing.org> Cc: Yang Yingliang <yangyingliang@huawei.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 88f5a9a commit b2ef51c

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/rapidio/devices/rio_mport_cdev.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1742,7 +1742,8 @@ static int rio_mport_add_riodev(struct mport_cdev_priv *priv,
17421742
err = rio_add_net(net);
17431743
if (err) {
17441744
rmcd_debug(RDEV, "failed to register net, err=%d", err);
1745-
kfree(net);
1745+
put_device(&net->dev);
1746+
mport->net = NULL;
17461747
goto cleanup;
17471748
}
17481749
}

0 commit comments

Comments
 (0)