ASoC: imx-audmix: Fix return error with devm_clk_get()

TE-N-ShengjiuWang · broonie · commit b19a5733de25 · 2023-09-15T13:16:21.000+01:00
The devm_clk_get() can return -EPROBE_DEFER error, modify the error code to be -EINVAL is not correct, which cause the -EPROBE_DEFER error is not correctly handled. This patch is to fix the return error code. Fixes: b86ef53 ("ASoC: fsl: Add Audio Mixer machine driver") Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> Link: https://lore.kernel.org/r/1694757731-18308-1-git-send-email-shengjiu.wang@nxp.com Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/fsl/imx-audmix.c b/sound/soc/fsl/imx-audmix.c
@@ -315,7 +315,7 @@ static int imx_audmix_probe(struct platform_device *pdev)
 	if (IS_ERR(priv->cpu_mclk)) {
 		ret = PTR_ERR(priv->cpu_mclk);
 		dev_err(&cpu_pdev->dev, "failed to get DAI mclk1: %d\n", ret);
-		return -EINVAL;
+		return ret;
 	}
 
 	priv->audmix_pdev = audmix_pdev;

Original file line number	Diff line number	Diff line change
`@@ -315,7 +315,7 @@ static int imx_audmix_probe(struct platform_device *pdev)`
`315`	`315`	`if (IS_ERR(priv->cpu_mclk)) {`
`316`	`316`	`ret = PTR_ERR(priv->cpu_mclk);`
`317`	`317`	`dev_err(&cpu_pdev->dev, "failed to get DAI mclk1: %d\n", ret);`
`318`		`- return -EINVAL;`
	`318`	`+ return ret;`
`319`	`319`	`}`
`320`	`320`
`321`	`321`	`priv->audmix_pdev = audmix_pdev;`