landlock: Remove KUnit test that triggers a warning

l0kod · l0kod · commit b1525d0a8d3a · 2025-05-03T08:55:42.000+02:00
A KUnit test checking boundaries triggers a canary warning, which may be disturbing. Let's remove this test for now. Hopefully, KUnit will soon get support for suppressing warning backtraces [1]. Cc: Alessandro Carminati <acarmina@redhat.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Günther Noack <gnoack@google.com> Reported-by: Tingmao Wang <m@maowtm.org> Closes: https://lore.kernel.org/r/20250327213807.12964-1-m@maowtm.org Link: https://lore.kernel.org/r/20250425193249.78b45d2589575c15f483c3d8@linux-foundation.org [1] Link: https://lore.kernel.org/r/20250503065359.3625407-1-mic@digikod.net Signed-off-by: Mickaël Salaün <mic@digikod.net>
diff --git a/security/landlock/audit.c b/security/landlock/audit.c
@@ -175,7 +175,7 @@ static void test_get_hierarchy(struct kunit *const test)
 	KUNIT_EXPECT_EQ(test, 10, get_hierarchy(&dom2, 0)->id);
 	KUNIT_EXPECT_EQ(test, 20, get_hierarchy(&dom2, 1)->id);
 	KUNIT_EXPECT_EQ(test, 30, get_hierarchy(&dom2, 2)->id);
-	KUNIT_EXPECT_EQ(test, 30, get_hierarchy(&dom2, -1)->id);
+	/* KUNIT_EXPECT_EQ(test, 30, get_hierarchy(&dom2, -1)->id); */
 }
 
 #endif /* CONFIG_SECURITY_LANDLOCK_KUNIT_TEST */

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ static void test_get_hierarchy(struct kunit *const test)`
`175`	`175`	`KUNIT_EXPECT_EQ(test, 10, get_hierarchy(&dom2, 0)->id);`
`176`	`176`	`KUNIT_EXPECT_EQ(test, 20, get_hierarchy(&dom2, 1)->id);`
`177`	`177`	`KUNIT_EXPECT_EQ(test, 30, get_hierarchy(&dom2, 2)->id);`
`178`		`- KUNIT_EXPECT_EQ(test, 30, get_hierarchy(&dom2, -1)->id);`
	`178`	`+ /* KUNIT_EXPECT_EQ(test, 30, get_hierarchy(&dom2, -1)->id); */`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`#endif /* CONFIG_SECURITY_LANDLOCK_KUNIT_TEST */`