Skip to content

Commit b1211a2

Browse files
committed
bdev: make bdev_{release, open_by_dev}() private to block layer
Move both of them to the private block header. There's no caller in the tree anymore that uses them directly. Link: https://lore.kernel.org/r/20240123-vfs-bdev-file-v2-28-adbd023e19cc@kernel.org Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent e97d06a commit b1211a2

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

block/bdev.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -916,7 +916,6 @@ struct bdev_handle *bdev_open_by_dev(dev_t dev, blk_mode_t mode, void *holder,
916916
kfree(handle);
917917
return ERR_PTR(ret);
918918
}
919-
EXPORT_SYMBOL(bdev_open_by_dev);
920919

921920
/*
922921
* If BLK_OPEN_WRITE_IOCTL is set then this is a historical quirk
@@ -1042,7 +1041,6 @@ void bdev_release(struct bdev_handle *handle)
10421041
blkdev_put_no_open(bdev);
10431042
kfree(handle);
10441043
}
1045-
EXPORT_SYMBOL(bdev_release);
10461044

10471045
/**
10481046
* lookup_bdev() - Look up a struct block_device by name.

block/blk.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -516,4 +516,8 @@ static inline int req_ref_read(struct request *req)
516516
return atomic_read(&req->ref);
517517
}
518518

519+
void bdev_release(struct bdev_handle *handle);
520+
struct bdev_handle *bdev_open_by_dev(dev_t dev, blk_mode_t mode, void *holder,
521+
const struct blk_holder_ops *hops);
522+
519523
#endif /* BLK_INTERNAL_H */

include/linux/blkdev.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1482,16 +1482,13 @@ struct bdev_handle {
14821482
blk_mode_t mode;
14831483
};
14841484

1485-
struct bdev_handle *bdev_open_by_dev(dev_t dev, blk_mode_t mode, void *holder,
1486-
const struct blk_holder_ops *hops);
14871485
struct file *bdev_file_open_by_dev(dev_t dev, blk_mode_t mode, void *holder,
14881486
const struct blk_holder_ops *hops);
14891487
struct file *bdev_file_open_by_path(const char *path, blk_mode_t mode,
14901488
void *holder, const struct blk_holder_ops *hops);
14911489
int bd_prepare_to_claim(struct block_device *bdev, void *holder,
14921490
const struct blk_holder_ops *hops);
14931491
void bd_abort_claiming(struct block_device *bdev, void *holder);
1494-
void bdev_release(struct bdev_handle *handle);
14951492

14961493
/* just for blk-cgroup, don't use elsewhere */
14971494
struct block_device *blkdev_get_no_open(dev_t dev);

0 commit comments

Comments
 (0)