Skip to content

Commit b11a74a

Browse files
Magniquicktiwai
authored andcommitted
ALSA: hda/realtek: Add mute LED quirk for HP Pavilion x360 14-dy1xxx
Add a fixup to enable the mute LED on HP Pavilion x360 Convertible 14-dy1xxx with ALC295 codec. The appropriate coefficient index and bits were identified through a brute-force method, as detailed in https://bbs.archlinux.org/viewtopic.php?pid=2079504#p2079504. Signed-off-by: Navon John Lukose <navonjohnlukose@gmail.com> Link: https://patch.msgid.link/20250307213319.35507-1-navonjohnlukose@gmail.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 8463d2a commit b11a74a

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

sound/pci/hda/patch_realtek.c

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4790,6 +4790,21 @@ static void alc236_fixup_hp_coef_micmute_led(struct hda_codec *codec,
47904790
}
47914791
}
47924792

4793+
static void alc295_fixup_hp_mute_led_coefbit11(struct hda_codec *codec,
4794+
const struct hda_fixup *fix, int action)
4795+
{
4796+
struct alc_spec *spec = codec->spec;
4797+
4798+
if (action == HDA_FIXUP_ACT_PRE_PROBE) {
4799+
spec->mute_led_polarity = 0;
4800+
spec->mute_led_coef.idx = 0xb;
4801+
spec->mute_led_coef.mask = 3 << 3;
4802+
spec->mute_led_coef.on = 1 << 3;
4803+
spec->mute_led_coef.off = 1 << 4;
4804+
snd_hda_gen_add_mute_led_cdev(codec, coef_mute_led_set);
4805+
}
4806+
}
4807+
47934808
static void alc285_fixup_hp_mute_led(struct hda_codec *codec,
47944809
const struct hda_fixup *fix, int action)
47954810
{
@@ -7656,6 +7671,7 @@ enum {
76567671
ALC290_FIXUP_MONO_SPEAKERS_HSJACK,
76577672
ALC290_FIXUP_SUBWOOFER,
76587673
ALC290_FIXUP_SUBWOOFER_HSJACK,
7674+
ALC295_FIXUP_HP_MUTE_LED_COEFBIT11,
76597675
ALC269_FIXUP_THINKPAD_ACPI,
76607676
ALC269_FIXUP_LENOVO_XPAD_ACPI,
76617677
ALC269_FIXUP_DMIC_THINKPAD_ACPI,
@@ -9401,6 +9417,10 @@ static const struct hda_fixup alc269_fixups[] = {
94019417
.chained = true,
94029418
.chain_id = ALC283_FIXUP_INT_MIC,
94039419
},
9420+
[ALC295_FIXUP_HP_MUTE_LED_COEFBIT11] = {
9421+
.type = HDA_FIXUP_FUNC,
9422+
.v.func = alc295_fixup_hp_mute_led_coefbit11,
9423+
},
94049424
[ALC298_FIXUP_SAMSUNG_AMP] = {
94059425
.type = HDA_FIXUP_FUNC,
94069426
.v.func = alc298_fixup_samsung_amp,
@@ -10451,6 +10471,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
1045110471
SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3),
1045210472
SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_FIXUP_HP_SPECTRE_X360),
1045310473
SND_PCI_QUIRK(0x103c, 0x8537, "HP ProBook 440 G6", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
10474+
SND_PCI_QUIRK(0x103c, 0x85c6, "HP Pavilion x360 Convertible 14-dy1xxx", ALC295_FIXUP_HP_MUTE_LED_COEFBIT11),
1045410475
SND_PCI_QUIRK(0x103c, 0x85de, "HP Envy x360 13-ar0xxx", ALC285_FIXUP_HP_ENVY_X360),
1045510476
SND_PCI_QUIRK(0x103c, 0x860f, "HP ZBook 15 G6", ALC285_FIXUP_HP_GPIO_AMP_INIT),
1045610477
SND_PCI_QUIRK(0x103c, 0x861f, "HP Elite Dragonfly G1", ALC285_FIXUP_HP_GPIO_AMP_INIT),

0 commit comments

Comments
 (0)