Skip to content

Commit b0a6da4

Browse files
rddunlapRussell King (Oracle)
authored andcommitted
ARM: 9318/1: locomo: move kernel-doc to prevent warnings
Move the kernel-doc comments for locomo_probe() to immediately before that function instead of before __locomo_probe() to prevent kernel-doc warnings. Adjust the documented function parameters and make the return values compatible with ReST by adding bullets to them. Add more possible return values to the list. Prevents these warnings: arch/arm/common/locomo.c:368: warning: Function parameter or member 'me' not described in '__locomo_probe' arch/arm/common/locomo.c:368: warning: Function parameter or member 'mem' not described in '__locomo_probe' arch/arm/common/locomo.c:368: warning: Function parameter or member 'irq' not described in '__locomo_probe' arch/arm/common/locomo.c:368: warning: expecting prototype for locomo_probe(). Prototype was for __locomo_probe() instead Link: lore.kernel.org/r/202308050851.zAvHe6y7-lkp@intel.com Fixes: 5eb6e28 ("ARM: 9289/1: Allow pre-ARMv5 builds with ld.lld 16.0.0 and newer") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Cc: Nick Desaulniers <ndesaulniers@google.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Nathan Chancellor <nathan@kernel.org> Cc: linux-arm-kernel@lists.infradead.org Cc: patches@armlinux.org.uk Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
1 parent 8922ba7 commit b0a6da4

File tree

1 file changed

+15
-13
lines changed

1 file changed

+15
-13
lines changed

arch/arm/common/locomo.c

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -350,19 +350,6 @@ static int locomo_resume(struct platform_device *dev)
350350
}
351351
#endif
352352

353-
354-
/**
355-
* locomo_probe - probe for a single LoCoMo chip.
356-
* @phys_addr: physical address of device.
357-
*
358-
* Probe for a LoCoMo chip. This must be called
359-
* before any other locomo-specific code.
360-
*
361-
* Returns:
362-
* %-ENODEV device not found.
363-
* %-EBUSY physical address already marked in-use.
364-
* %0 successful.
365-
*/
366353
static int
367354
__locomo_probe(struct device *me, struct resource *mem, int irq)
368355
{
@@ -479,6 +466,21 @@ static void __locomo_remove(struct locomo *lchip)
479466
kfree(lchip);
480467
}
481468

469+
/**
470+
* locomo_probe - probe for a single LoCoMo chip.
471+
* @dev: platform device
472+
*
473+
* Probe for a LoCoMo chip. This must be called
474+
* before any other locomo-specific code.
475+
*
476+
* Returns:
477+
* * %-EINVAL - device's IORESOURCE_MEM not found
478+
* * %-ENXIO - could not allocate an IRQ for the device
479+
* * %-ENODEV - device not found.
480+
* * %-EBUSY - physical address already marked in-use.
481+
* * %-ENOMEM - could not allocate or iomap memory.
482+
* * %0 - successful.
483+
*/
482484
static int locomo_probe(struct platform_device *dev)
483485
{
484486
struct resource *mem;

0 commit comments

Comments
 (0)