Skip to content

Commit b049e7a

Browse files
a3fBartosz Golaszewski
authored andcommitted
gpio: mxc: remove dead code after switch to DT-only
struct platform_device::id was only set by board code, but since i.MX became a devicetree-only platform, this will always be -1 (PLATFORM_DEVID_NONE). Note: of_alias_get_id() returns a negative number on error and base treats all negative errors the same, so we need not add any additional error handling. Fixes: 0f2c7af ("gpio: mxc: Convert the driver to DT-only") Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Reviewed-by: Andy Shevchenko <andy@kernel.org> Link: https://lore.kernel.org/r/20250113-b4-imx-gpio-base-warning-v1-3-0a28731a5cf6@pengutronix.de Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
1 parent 4abae5b commit b049e7a

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/gpio/gpio-mxc.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -490,8 +490,7 @@ static int mxc_gpio_probe(struct platform_device *pdev)
490490
port->gc.request = mxc_gpio_request;
491491
port->gc.free = mxc_gpio_free;
492492
port->gc.to_irq = mxc_gpio_to_irq;
493-
port->gc.base = (pdev->id < 0) ? of_alias_get_id(np, "gpio") * 32 :
494-
pdev->id * 32;
493+
port->gc.base = of_alias_get_id(np, "gpio") * 32;
495494

496495
err = devm_gpiochip_add_data(&pdev->dev, &port->gc, port);
497496
if (err)

0 commit comments

Comments
 (0)