Skip to content

Commit af00d48

Browse files
metiulekmdlezcano
authored andcommitted
thermal/drivers/exynos: Use BIT wherever possible
The original driver did not use that macro and it allows us to make our intentions slightly clearer. Reviewed-by: Lukasz Luba <lukasz.luba@arm.com> Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/20231201095625.301884-9-m.majewski2@samsung.com
1 parent b72ba67 commit af00d48

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

drivers/thermal/samsung/exynos_tmu.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ static void exynos4412_tmu_set_trip_temp(struct exynos_tmu_data *data,
388388

389389
if (trip == 3) {
390390
con = readl(data->base + EXYNOS_TMU_REG_CONTROL);
391-
con |= (1 << EXYNOS_TMU_THERM_TRIP_EN_SHIFT);
391+
con |= BIT(EXYNOS_TMU_THERM_TRIP_EN_SHIFT);
392392
writel(con, data->base + EXYNOS_TMU_REG_CONTROL);
393393
}
394394
}
@@ -559,16 +559,16 @@ static void exynos4210_tmu_control(struct platform_device *pdev, bool on)
559559
continue;
560560

561561
interrupt_en |=
562-
(1 << (EXYNOS_TMU_INTEN_RISE0_SHIFT + i * 4));
562+
BIT(EXYNOS_TMU_INTEN_RISE0_SHIFT + i * 4);
563563
}
564564

565565
if (data->soc != SOC_ARCH_EXYNOS4210)
566566
interrupt_en |=
567567
interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT;
568568

569-
con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT);
569+
con |= BIT(EXYNOS_TMU_CORE_EN_SHIFT);
570570
} else {
571-
con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT);
571+
con &= ~BIT(EXYNOS_TMU_CORE_EN_SHIFT);
572572
}
573573

574574
writel(interrupt_en, data->base + EXYNOS_TMU_REG_INTEN);
@@ -590,15 +590,15 @@ static void exynos5433_tmu_control(struct platform_device *pdev, bool on)
590590
continue;
591591

592592
interrupt_en |=
593-
(1 << (EXYNOS7_TMU_INTEN_RISE0_SHIFT + i));
593+
BIT(EXYNOS7_TMU_INTEN_RISE0_SHIFT + i);
594594
}
595595

596596
interrupt_en |=
597597
interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT;
598598

599-
con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT);
599+
con |= BIT(EXYNOS_TMU_CORE_EN_SHIFT);
600600
} else
601-
con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT);
601+
con &= ~BIT(EXYNOS_TMU_CORE_EN_SHIFT);
602602

603603
pd_det_en = on ? EXYNOS5433_PD_DET_EN : 0;
604604

@@ -622,17 +622,17 @@ static void exynos7_tmu_control(struct platform_device *pdev, bool on)
622622
continue;
623623

624624
interrupt_en |=
625-
(1 << (EXYNOS7_TMU_INTEN_RISE0_SHIFT + i));
625+
BIT(EXYNOS7_TMU_INTEN_RISE0_SHIFT + i);
626626
}
627627

628628
interrupt_en |=
629629
interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT;
630630

631-
con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT);
632-
con |= (1 << EXYNOS7_PD_DET_EN_SHIFT);
631+
con |= BIT(EXYNOS_TMU_CORE_EN_SHIFT);
632+
con |= BIT(EXYNOS7_PD_DET_EN_SHIFT);
633633
} else {
634-
con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT);
635-
con &= ~(1 << EXYNOS7_PD_DET_EN_SHIFT);
634+
con &= ~BIT(EXYNOS_TMU_CORE_EN_SHIFT);
635+
con &= ~BIT(EXYNOS7_PD_DET_EN_SHIFT);
636636
}
637637

638638
writel(interrupt_en, data->base + EXYNOS7_TMU_REG_INTEN);

0 commit comments

Comments
 (0)