Skip to content

Commit ad24919

Browse files
rfvirgilbroonie
authored andcommitted
firmware: cs_dsp: Log correct region name in bin error messages
In cs_dsp_load_coeff() region_name should be set in the XM/YM/ZM cases otherwise any errors will log the region as "Unknown". While doing this also change one error message that logged the region type ID to log the region_name instead. This makes it consistent with other messages in the same function. Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Link: https://lore.kernel.org/r/20230605143238.4001982-1-rf@opensource.cirrus.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 32cf004 commit ad24919

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/firmware/cirrus/cs_dsp.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2124,6 +2124,7 @@ static int cs_dsp_load_coeff(struct cs_dsp *dsp, const struct firmware *firmware
21242124
file, blocks, le32_to_cpu(blk->len),
21252125
type, le32_to_cpu(blk->id));
21262126

2127+
region_name = cs_dsp_mem_region_name(type);
21272128
mem = cs_dsp_find_region(dsp, type);
21282129
if (!mem) {
21292130
cs_dsp_err(dsp, "No base for region %x\n", type);
@@ -2147,8 +2148,8 @@ static int cs_dsp_load_coeff(struct cs_dsp *dsp, const struct firmware *firmware
21472148
reg = dsp->ops->region_to_reg(mem, reg);
21482149
reg += offset;
21492150
} else {
2150-
cs_dsp_err(dsp, "No %x for algorithm %x\n",
2151-
type, le32_to_cpu(blk->id));
2151+
cs_dsp_err(dsp, "No %s for algorithm %x\n",
2152+
region_name, le32_to_cpu(blk->id));
21522153
}
21532154
break;
21542155

0 commit comments

Comments
 (0)