Skip to content

Commit acea28a

Browse files
Stefan Haberlandaxboe
authored andcommitted
s390/dasd: use correct number of retries for ERP requests
If a DASD request fails an error recovery procedure (ERP) request might be built as a copy of the original request to do error recovery. The ERP request gets a number of retries assigned. This number is always 256 no matter what other value might have been set for the original request. This is not what is expected when a user specifies a certain amount of retries for the device via sysfs. Correctly use the number of retries of the original request for ERP requests. Signed-off-by: Stefan Haberland <sth@linux.ibm.com> Reviewed-by: Jan Hoeppner <hoeppner@linux.ibm.com> Link: https://lore.kernel.org/r/20230721193647.3889634-3-sth@linux.ibm.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 05f1d8e commit acea28a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/s390/block/dasd_3990_erp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2441,7 +2441,7 @@ static struct dasd_ccw_req *dasd_3990_erp_add_erp(struct dasd_ccw_req *cqr)
24412441
erp->block = cqr->block;
24422442
erp->magic = cqr->magic;
24432443
erp->expires = cqr->expires;
2444-
erp->retries = 256;
2444+
erp->retries = device->default_retries;
24452445
erp->buildclk = get_tod_clock();
24462446
erp->status = DASD_CQR_FILLED;
24472447

0 commit comments

Comments
 (0)