Skip to content

Commit ac168d6

Browse files
TommyHuang0527Wolfram Sang
authored andcommitted
i2c: aspeed: Fix the dummy irq expected print
When the i2c error condition occurred and master state was not idle, the master irq function will goto complete state without any other interrupt handling. It would cause dummy irq expected print. Under this condition, assign the irq_status into irq_handle. For example, when the abnormal start / stop occurred (bit 5) with normal stop status (bit 4) at same time. Then the normal stop status would not be handled and it would cause irq expected print in the aspeed_i2c_bus_irq. ... aspeed-i2c-bus x. i2c-bus: irq handled != irq. Expected 0x00000030, but was 0x00000020 ... Fixes: 3e9efc3 ("i2c: aspeed: Handle master/slave combined irq events properly") Cc: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com> Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
1 parent 97fd62e commit ac168d6

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/i2c/busses/i2c-aspeed.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -445,6 +445,7 @@ static u32 aspeed_i2c_master_irq(struct aspeed_i2c_bus *bus, u32 irq_status)
445445
irq_status);
446446
irq_handled |= (irq_status & ASPEED_I2CD_INTR_MASTER_ERRORS);
447447
if (bus->master_state != ASPEED_I2C_MASTER_INACTIVE) {
448+
irq_handled = irq_status;
448449
bus->cmd_err = ret;
449450
bus->master_state = ASPEED_I2C_MASTER_INACTIVE;
450451
goto out_complete;

0 commit comments

Comments
 (0)