Skip to content

Commit ab8eb79

Browse files
Yuuoniydavem330
authored andcommitted
net: bcmgenet: Fix NULL vs IS_ERR() checking
The phy_attach() function does not return NULL. It returns error pointers. Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent c062f2a commit ab8eb79

File tree

1 file changed

+2
-2
lines changed
  • drivers/net/ethernet/broadcom/genet

1 file changed

+2
-2
lines changed

drivers/net/ethernet/broadcom/genet/bcmmii.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -589,9 +589,9 @@ static int bcmgenet_mii_pd_init(struct bcmgenet_priv *priv)
589589
* Internal or external PHY with MDIO access
590590
*/
591591
phydev = phy_attach(priv->dev, phy_name, pd->phy_interface);
592-
if (!phydev) {
592+
if (IS_ERR(phydev)) {
593593
dev_err(kdev, "failed to register PHY device\n");
594-
return -ENODEV;
594+
return PTR_ERR(phydev);
595595
}
596596
} else {
597597
/*

0 commit comments

Comments
 (0)