Skip to content

Commit ab3de2c

Browse files
Aapo Vienamowesteri
authored andcommitted
thunderbolt: Fix memory leaks in {port|retimer}_sb_regs_write()
Add missing free_page() call for the memory allocated by validate_and_copy_from_user(). Fixes: 6d241fa ("thunderbolt: Add sideband register access to debugfs") Signed-off-by: Aapo Vienamo <aapo.vienamo@linux.intel.com> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
1 parent 8400291 commit ab3de2c

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

drivers/thunderbolt/debugfs.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -323,16 +323,17 @@ static ssize_t port_sb_regs_write(struct file *file, const char __user *user_buf
323323

324324
if (mutex_lock_interruptible(&tb->lock)) {
325325
ret = -ERESTARTSYS;
326-
goto out_rpm_put;
326+
goto out;
327327
}
328328

329329
ret = sb_regs_write(port, port_sb_regs, ARRAY_SIZE(port_sb_regs),
330330
USB4_SB_TARGET_ROUTER, 0, buf, count, ppos);
331331

332332
mutex_unlock(&tb->lock);
333-
out_rpm_put:
333+
out:
334334
pm_runtime_mark_last_busy(&sw->dev);
335335
pm_runtime_put_autosuspend(&sw->dev);
336+
free_page((unsigned long)buf);
336337

337338
return ret < 0 ? ret : count;
338339
}
@@ -355,16 +356,17 @@ static ssize_t retimer_sb_regs_write(struct file *file,
355356

356357
if (mutex_lock_interruptible(&tb->lock)) {
357358
ret = -ERESTARTSYS;
358-
goto out_rpm_put;
359+
goto out;
359360
}
360361

361362
ret = sb_regs_write(rt->port, retimer_sb_regs, ARRAY_SIZE(retimer_sb_regs),
362363
USB4_SB_TARGET_RETIMER, rt->index, buf, count, ppos);
363364

364365
mutex_unlock(&tb->lock);
365-
out_rpm_put:
366+
out:
366367
pm_runtime_mark_last_busy(&rt->dev);
367368
pm_runtime_put_autosuspend(&rt->dev);
369+
free_page((unsigned long)buf);
368370

369371
return ret < 0 ? ret : count;
370372
}

0 commit comments

Comments
 (0)