Skip to content

Commit ab09fb9

Browse files
kv2019ibroonie
authored andcommitted
ASoC: SOF: ipc4-loader: remove the CPC check warnings
Warnings related to missing data in firmware manifest have proven to be too verbose. This relates to description of DSP module cost expressed in cycles per chunk (CPC). If a matching value is not found in the manifest, kernel will pass a zero value and DSP firmware will use a conservative value in its place. Downgrade the warnings to dev_dbg(). Fixes: d8a2c98 ("ASoC: SOF: ipc4-loader/topology: Query the CPC value from manifest") Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com> Reviewed-by: Liam Girdwood <liam.r.girdwood@intel.com> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> Link: https://msgid.link/r/20240115092209.7184-3-peter.ujfalusi@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 848c8f5 commit ab09fb9

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

sound/soc/sof/ipc4-loader.c

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -482,13 +482,10 @@ void sof_ipc4_update_cpc_from_manifest(struct snd_sof_dev *sdev,
482482
msg = "No CPC match in the firmware file's manifest";
483483

484484
no_cpc:
485-
dev_warn(sdev->dev, "%s (UUID: %pUL): %s (ibs/obs: %u/%u)\n",
486-
fw_module->man4_module_entry.name,
487-
&fw_module->man4_module_entry.uuid, msg, basecfg->ibs,
488-
basecfg->obs);
489-
dev_warn_once(sdev->dev, "Please try to update the firmware.\n");
490-
dev_warn_once(sdev->dev, "If the issue persists, file a bug at\n");
491-
dev_warn_once(sdev->dev, "https://github.com/thesofproject/sof/issues/\n");
485+
dev_dbg(sdev->dev, "%s (UUID: %pUL): %s (ibs/obs: %u/%u)\n",
486+
fw_module->man4_module_entry.name,
487+
&fw_module->man4_module_entry.uuid, msg, basecfg->ibs,
488+
basecfg->obs);
492489
}
493490

494491
const struct sof_ipc_fw_loader_ops ipc4_loader_ops = {

0 commit comments

Comments
 (0)