Skip to content

Commit aa44433

Browse files
hcahcaVasily Gorbik
authored andcommitted
s390: add USER_STACKTRACE support
Use the perf_callchain_user() code as blueprint to also add support for USER_STACKTRACE. To describe how to use this cite the commit message of the LoongArch implementation which came with commit 4d7bf93 ("LoongArch: Add USER_STACKTRACE support"), but replace -fno-omit-frame-pointer option with the s390 specific -mbackchain option: ====================================================================== To get the best stacktrace output, you can compile your userspace programs with frame pointers (at least glibc + the app you are tracing). 1, export "CC = gcc -mbackchain"; 2, compile your programs with "CC"; 3, use uprobe to get stacktrace output. ... echo 'p:malloc /usr/lib64/libc.so.6:0x0a4704 size=%r2:u64' > uprobe_events echo 'p:free /usr/lib64/libc.so.6:0x0a4d50 ptr=%r2:u64' >> uprobe_events echo 'comm == "demo"' > ./events/uprobes/malloc/filter echo 'comm == "demo"' > ./events/uprobes/free/filter echo 1 > ./options/userstacktrace echo 1 > ./options/sym-userobj ... ====================================================================== Signed-off-by: Heiko Carstens <hca@linux.ibm.com> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
1 parent 504b73d commit aa44433

File tree

2 files changed

+44
-0
lines changed

2 files changed

+44
-0
lines changed

arch/s390/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,7 @@ config S390
236236
select THREAD_INFO_IN_TASK
237237
select TRACE_IRQFLAGS_SUPPORT
238238
select TTY
239+
select USER_STACKTRACE_SUPPORT
239240
select VIRT_CPU_ACCOUNTING
240241
select ZONE_DMA
241242
# Note: keep the above list sorted alphabetically

arch/s390/kernel/stacktrace.c

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,12 @@
66
*/
77

88
#include <linux/stacktrace.h>
9+
#include <linux/uaccess.h>
10+
#include <linux/compat.h>
911
#include <asm/stacktrace.h>
1012
#include <asm/unwind.h>
1113
#include <asm/kprobes.h>
14+
#include <asm/ptrace.h>
1215

1316
void arch_stack_walk(stack_trace_consume_fn consume_entry, void *cookie,
1417
struct task_struct *task, struct pt_regs *regs)
@@ -58,3 +61,43 @@ int arch_stack_walk_reliable(stack_trace_consume_fn consume_entry,
5861
return -EINVAL;
5962
return 0;
6063
}
64+
65+
void arch_stack_walk_user(stack_trace_consume_fn consume_entry, void *cookie,
66+
const struct pt_regs *regs)
67+
{
68+
struct stack_frame_user __user *sf;
69+
unsigned long ip, sp;
70+
bool first = true;
71+
72+
if (is_compat_task())
73+
return;
74+
if (!consume_entry(cookie, instruction_pointer(regs)))
75+
return;
76+
sf = (void __user *)user_stack_pointer(regs);
77+
pagefault_disable();
78+
while (1) {
79+
if (__get_user(sp, &sf->back_chain))
80+
break;
81+
if (__get_user(ip, &sf->gprs[8]))
82+
break;
83+
if (ip & 0x1) {
84+
/*
85+
* If the instruction address is invalid, and this
86+
* is the first stack frame, assume r14 has not
87+
* been written to the stack yet. Otherwise exit.
88+
*/
89+
if (first && !(regs->gprs[14] & 0x1))
90+
ip = regs->gprs[14];
91+
else
92+
break;
93+
}
94+
if (!consume_entry(cookie, ip))
95+
break;
96+
/* Sanity check: ABI requires SP to be aligned 8 bytes. */
97+
if (!sp || sp & 0x7)
98+
break;
99+
sf = (void __user *)sp;
100+
first = false;
101+
}
102+
pagefault_enable();
103+
}

0 commit comments

Comments
 (0)