Skip to content

Commit aa23317

Browse files
author
Al Viro
committed
qibfs: fix dentry leak
simple_recursive_removal() drops the pinning references to all positives in subtree. For the cases when its argument has been kept alive by the pinning alone that's exactly the right thing to do, but here the argument comes from dcache lookup, that needs to be balanced by explicit dput(). Fixes: e41d237 "qib_fs: switch to simple_recursive_removal()" Fucked-up-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent 2c88c16 commit aa23317

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/infiniband/hw/qib/qib_fs.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -439,6 +439,7 @@ static int remove_device_files(struct super_block *sb,
439439
return PTR_ERR(dir);
440440
}
441441
simple_recursive_removal(dir, NULL);
442+
dput(dir);
442443
return 0;
443444
}
444445

0 commit comments

Comments
 (0)