Skip to content

Commit a98151a

Browse files
tehcasterrostedt
authored andcommitted
ring-buffer: remove obsolete comment for free_buffer_page()
The comment refers to mm/slob.c which is being removed. It comes from commit ed56829 ("ring_buffer: reset buffer page when freeing") and according to Steven the borrowed code was a page mapcount and mapping reset, which was later removed by commit e4c2ce8 ("ring_buffer: allocate buffer page pointer"). Thus the comment is not accurate anyway, remove it. Link: https://lore.kernel.org/linux-trace-kernel/20230315142446.27040-1-vbabka@suse.cz Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Ingo Molnar <mingo@elte.hu> Reported-by: Mike Rapoport <mike.rapoport@gmail.com> Suggested-by: Steven Rostedt (Google) <rostedt@goodmis.org> Fixes: e4c2ce8 ("ring_buffer: allocate buffer page pointer") Signed-off-by: Vlastimil Babka <vbabka@suse.cz> Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent e400be6 commit a98151a

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

kernel/trace/ring_buffer.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -354,10 +354,6 @@ static void rb_init_page(struct buffer_data_page *bpage)
354354
local_set(&bpage->commit, 0);
355355
}
356356

357-
/*
358-
* Also stolen from mm/slob.c. Thanks to Mathieu Desnoyers for pointing
359-
* this issue out.
360-
*/
361357
static void free_buffer_page(struct buffer_page *bpage)
362358
{
363359
free_page((unsigned long)bpage->page);

0 commit comments

Comments
 (0)