Skip to content

Commit a87852e

Browse files
Kwiboommind
authored andcommitted
arm64: dts: rockchip: Fix PCIe regulators on Radxa E25
Despite its name, the regulator vcc3v3_pcie30x1 has nothing to do with pcie30x1. Instead, it supply power to VBAT1-5 on the M.2 KEY B port as seen on page 8 of the schematic [1]. pcie30x1 is used for the mini PCIe slot, and as seen on page 9 the vcc3v3_minipcie regulator is instead related to pcie30x1. The M.2 KEY B port can be used for WWAN USB2 modules or SATA drives. Use correct regulator vcc3v3_minipcie for pcie30x1. [1] https://dl.radxa.com/cm3p/e25/radxa-e25-v1.4-sch.pdf Fixes: 2bf2f4d ("arm64: dts: rockchip: Add Radxa CM3I E25") Signed-off-by: Jonas Karlman <jonas@kwiboo.se> Link: https://lore.kernel.org/r/20230724145213.3833099-1-jonas@kwiboo.se Signed-off-by: Heiko Stuebner <heiko@sntech.de>
1 parent a02913e commit a87852e

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,16 +47,19 @@
4747
vin-supply = <&vcc5v0_sys>;
4848
};
4949

50+
/* actually fed by vcc5v0_sys, dependent
51+
* on pi6c clock generator
52+
*/
5053
vcc3v3_minipcie: vcc3v3-minipcie-regulator {
5154
compatible = "regulator-fixed";
5255
enable-active-high;
5356
gpio = <&gpio3 RK_PA7 GPIO_ACTIVE_HIGH>;
5457
pinctrl-names = "default";
5558
pinctrl-0 = <&minipcie_enable_h>;
5659
regulator-name = "vcc3v3_minipcie";
57-
regulator-min-microvolt = <5000000>;
58-
regulator-max-microvolt = <5000000>;
59-
vin-supply = <&vcc5v0_sys>;
60+
regulator-min-microvolt = <3300000>;
61+
regulator-max-microvolt = <3300000>;
62+
vin-supply = <&vcc3v3_pi6c_05>;
6063
};
6164

6265
vcc3v3_ngff: vcc3v3-ngff-regulator {
@@ -71,9 +74,6 @@
7174
vin-supply = <&vcc5v0_sys>;
7275
};
7376

74-
/* actually fed by vcc5v0_sys, dependent
75-
* on pi6c clock generator
76-
*/
7777
vcc3v3_pcie30x1: vcc3v3-pcie30x1-regulator {
7878
compatible = "regulator-fixed";
7979
enable-active-high;
@@ -83,7 +83,7 @@
8383
regulator-name = "vcc3v3_pcie30x1";
8484
regulator-min-microvolt = <3300000>;
8585
regulator-max-microvolt = <3300000>;
86-
vin-supply = <&vcc3v3_pi6c_05>;
86+
vin-supply = <&vcc5v0_sys>;
8787
};
8888

8989
vcc3v3_pi6c_05: vcc3v3-pi6c-05-regulator {
@@ -117,7 +117,7 @@
117117
pinctrl-names = "default";
118118
pinctrl-0 = <&pcie30x1m0_pins>;
119119
reset-gpios = <&gpio0 RK_PC3 GPIO_ACTIVE_HIGH>;
120-
vpcie3v3-supply = <&vcc3v3_pcie30x1>;
120+
vpcie3v3-supply = <&vcc3v3_minipcie>;
121121
status = "okay";
122122
};
123123

0 commit comments

Comments
 (0)