Skip to content

Commit a754012

Browse files
keithbuschChristoph Hellwig
authored andcommitted
nvme-pci: fix queue unquiesce check on slot_reset
A zero return means the reset was successfully scheduled. We don't want to unquiesce the queues while the reset_work is pending, as that will just flush out requeued requests to a failed completion. Fixes: 71a5bb1 ("nvme: ensure disabling pairs with unquiesce") Reported-by: Dhankaran Singh Ajravat <dhankaran@meta.com> Signed-off-by: Keith Busch <kbusch@kernel.org> Signed-off-by: Christoph Hellwig <hch@lst.de>
1 parent a584b26 commit a754012

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/nvme/host/pci.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3575,7 +3575,7 @@ static pci_ers_result_t nvme_slot_reset(struct pci_dev *pdev)
35753575

35763576
dev_info(dev->ctrl.device, "restart after slot reset\n");
35773577
pci_restore_state(pdev);
3578-
if (!nvme_try_sched_reset(&dev->ctrl))
3578+
if (nvme_try_sched_reset(&dev->ctrl))
35793579
nvme_unquiesce_io_queues(&dev->ctrl);
35803580
return PCI_ERS_RESULT_RECOVERED;
35813581
}

0 commit comments

Comments
 (0)