Skip to content

Commit a6b4ec3

Browse files
neilbrownchucklever
authored andcommitted
SUNRPC: change svc_rqst::rq_flags bits to enum
When a sequence of numbers are needed for internal-use only, an enum is typically best. The sequence will inevitably need to be changed one day, and having an enum means the developer doesn't need to think about renumbering after insertion or deletion. Such patches will be easier to review. Signed-off-by: NeilBrown <neilb@suse.de> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent 3275694 commit a6b4ec3

File tree

1 file changed

+13
-10
lines changed
  • include/linux/sunrpc

1 file changed

+13
-10
lines changed

include/linux/sunrpc/svc.h

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -222,16 +222,6 @@ struct svc_rqst {
222222
u32 rq_proc; /* procedure number */
223223
u32 rq_prot; /* IP protocol */
224224
int rq_cachetype; /* catering to nfsd */
225-
#define RQ_SECURE (0) /* secure port */
226-
#define RQ_LOCAL (1) /* local request */
227-
#define RQ_USEDEFERRAL (2) /* use deferral */
228-
#define RQ_DROPME (3) /* drop current reply */
229-
#define RQ_SPLICE_OK (4) /* turned off in gss privacy
230-
* to prevent encrypting page
231-
* cache pages */
232-
#define RQ_VICTIM (5) /* about to be shut down */
233-
#define RQ_BUSY (6) /* request is busy */
234-
#define RQ_DATA (7) /* request has data */
235225
unsigned long rq_flags; /* flags field */
236226
ktime_t rq_qtime; /* enqueue time */
237227

@@ -262,6 +252,19 @@ struct svc_rqst {
262252
void ** rq_lease_breaker; /* The v4 client breaking a lease */
263253
};
264254

255+
/* bits for rq_flags */
256+
enum {
257+
RQ_SECURE, /* secure port */
258+
RQ_LOCAL, /* local request */
259+
RQ_USEDEFERRAL, /* use deferral */
260+
RQ_DROPME, /* drop current reply */
261+
RQ_SPLICE_OK, /* turned off in gss privacy to prevent
262+
* encrypting page cache pages */
263+
RQ_VICTIM, /* about to be shut down */
264+
RQ_BUSY, /* request is busy */
265+
RQ_DATA, /* request has data */
266+
};
267+
265268
#define SVC_NET(rqst) (rqst->rq_xprt ? rqst->rq_xprt->xpt_net : rqst->rq_bc_net)
266269

267270
/*

0 commit comments

Comments
 (0)