Skip to content

Commit a663520

Browse files
namhyungacmel
authored andcommitted
perf annotate: Set error stream of objdump process for TUI
The stderr should be set to a pipe when using TUI. Otherwise it'd print to stdout and break TUI windows with an error message. Signed-off-by: Namhyung Kim <namhyung@kernel.org> Cc: Andi Kleen <ak@linux.intel.com> Cc: Ian Rogers <irogers@google.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lore.kernel.org/lkml/20220202070828.143303-2-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent ae65b44 commit a663520

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tools/perf/util/annotate.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2036,6 +2036,7 @@ static int symbol__disassemble(struct symbol *sym, struct annotate_args *args)
20362036
memset(&objdump_process, 0, sizeof(objdump_process));
20372037
objdump_process.argv = objdump_argv;
20382038
objdump_process.out = -1;
2039+
objdump_process.err = -1;
20392040
if (start_command(&objdump_process)) {
20402041
pr_err("Failure starting to run %s\n", command);
20412042
err = -1;

0 commit comments

Comments
 (0)