Skip to content

Commit a65cdff

Browse files
arndbbroonie
authored andcommitted
ASoC: amd: acp: select SND_SOC_AMD_ACP_LEGACY_COMMON for ACP63
Without this dependency, acp63 fails to link: x86_64-linux-ld: sound/soc/amd/acp/acp63.o: in function `acp63_audio_remove': acp63.c:(.text+0x22): undefined reference to `acp_disable_interrupts' x86_64-linux-ld: sound/soc/amd/acp/acp63.o: in function `acp63_i2s_master_clock_generate.isra.0': acp63.c:(.text+0x6f): undefined reference to `smn_read' x86_64-linux-ld: acp63.c:(.text+0x81): undefined reference to `smn_write' x86_64-linux-ld: acp63.c:(.text+0x8e): undefined reference to `smn_read' x86_64-linux-ld: sound/soc/amd/acp/acp63.o: in function `acp63_pcm_resume': acp63.c:(.text+0x230): undefined reference to `restore_acp_i2s_params' x86_64-linux-ld: acp63.c:(.text+0x23d): undefined reference to `restore_acp_pdm_params' x86_64-linux-ld: sound/soc/amd/acp/acp63.o: in function `acp63_audio_probe': acp63.c:(.text+0x474): undefined reference to `acp_enable_interrupts' Fixes: d4c2d53 ("ASoC: amd: acp: add Kconfig options for acp6.3 based platform driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/r/20231027152403.386257-3-arnd@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent cf046ec commit a65cdff

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

sound/soc/amd/acp/Kconfig

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -61,15 +61,17 @@ config SND_AMD_ASOC_REMBRANDT
6161
If unsure select "N".
6262

6363
config SND_AMD_ASOC_ACP63
64-
tristate "AMD ACP ASOC ACP6.3 Support"
65-
select SND_SOC_AMD_ACP_PCM
66-
select SND_SOC_AMD_ACP_I2S
67-
select SND_SOC_AMD_ACP_PDM
68-
depends on X86 && PCI
69-
help
70-
This option enables Acp6.3 I2S support on AMD platform.
71-
Say Y if you want to enable AUDIO on ACP6.3
72-
If unsure select "N".
64+
tristate "AMD ACP ASOC ACP6.3 Support"
65+
depends on X86 && PCI
66+
depends on ACPI
67+
select SND_SOC_AMD_ACP_PCM
68+
select SND_SOC_AMD_ACP_I2S
69+
select SND_SOC_AMD_ACP_PDM
70+
select SND_SOC_AMD_ACP_LEGACY_COMMON
71+
help
72+
This option enables Acp6.3 I2S support on AMD platform.
73+
Say Y if you want to enable AUDIO on ACP6.3
74+
If unsure select "N".
7375

7476
config SND_SOC_AMD_MACH_COMMON
7577
tristate

0 commit comments

Comments
 (0)