Skip to content

Commit a648fde

Browse files
committed
NFSD: Fix NFSv3 SETATTR/CREATE's handling of large file sizes
iattr::ia_size is a loff_t, so these NFSv3 procedures must be careful to deal with incoming client size values that are larger than s64_max without corrupting the value. Silently capping the value results in storing a different value than the client passed in which is unexpected behavior, so remove the min_t() check in decode_sattr3(). Note that RFC 1813 permits only the WRITE procedure to return NFS3ERR_FBIG. We believe that NFSv3 reference implementations also return NFS3ERR_FBIG when ia_size is too large. Cc: stable@vger.kernel.org Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent e6faac3 commit a648fde

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/nfsd/nfs3xdr.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ svcxdr_decode_sattr3(struct svc_rqst *rqstp, struct xdr_stream *xdr,
254254
if (xdr_stream_decode_u64(xdr, &newsize) < 0)
255255
return false;
256256
iap->ia_valid |= ATTR_SIZE;
257-
iap->ia_size = min_t(u64, newsize, NFS_OFFSET_MAX);
257+
iap->ia_size = newsize;
258258
}
259259
if (xdr_stream_decode_u32(xdr, &set_it) < 0)
260260
return false;

0 commit comments

Comments
 (0)