ARM: OMAP2+: Fix an IS_ERR() vs NULL check in _get_pwrdm()

hiss2018 · tmlind · commit a58cfdba2039 · 2020-08-17T14:25:23.000+03:00
The of_clk_get() function returns error pointers, it never returns NULL. Fixes: 4ea3711 ("ARM: OMAP2+: omap-iommu.c conversion to ti-sysc") Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> Signed-off-by: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/mach-omap2/omap-iommu.c b/arch/arm/mach-omap2/omap-iommu.c
@@ -74,7 +74,7 @@ static struct powerdomain *_get_pwrdm(struct device *dev)
 		return pwrdm;
 
 	clk = of_clk_get(dev->of_node->parent, 0);
-	if (!clk) {
+	if (IS_ERR(clk)) {
 		dev_err(dev, "no fck found\n");
 		return NULL;
 	}

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ static struct powerdomain _get_pwrdm(struct device dev)`
`74`	`74`	`return pwrdm;`
`75`	`75`
`76`	`76`	`clk = of_clk_get(dev->of_node->parent, 0);`
`77`		`- if (!clk) {`
	`77`	`+ if (IS_ERR(clk)) {`
`78`	`78`	`dev_err(dev, "no fck found\n");`
`79`	`79`	`return NULL;`
`80`	`80`	`}`