Skip to content

Commit a55bdad

Browse files
superm1ij-intel
authored andcommitted
platform/x86/amd/pmc: Disable keyboard wakeup on AMD Framework 13
The Laptop 13 (AMD Ryzen 7040Series) BIOS 03.03 has a workaround included in the EC firmware that will cause the EC to emit a "spurious" keypress during the resume from s0i3 [1]. This series of keypress events can be observed in the kernel log on resume. ``` atkbd serio0: Unknown key pressed (translated set 2, code 0x6b on isa0060/serio0). atkbd serio0: Use 'setkeycodes 6b <keycode>' to make it known. atkbd serio0: Unknown key released (translated set 2, code 0x6b on isa0060/serio0). atkbd serio0: Use 'setkeycodes 6b <keycode>' to make it known. ``` In some user flows this is harmless, but if a user has specifically suspended the laptop and then closed the lid it will cause the laptop to wakeup. The laptop wakes up because the ACPI SCI triggers when the lid is closed and when the kernel sees that IRQ1 is "also" active. The kernel can't distinguish from a real keyboard keypress and wakes the system. Add the model into the list of quirks to disable keyboard wakeup source. This is intentionally only matching the production BIOS version in hopes that a newer EC firmware included in a newer BIOS can avoid this behavior. Cc: Kieran Levin <ktl@framework.net> Link: https://github.com/FrameworkComputer/EmbeddedController/blob/lotus-zephyr/zephyr/program/lotus/azalea/src/power_sequence.c#L313 [1] Link: https://community.frame.work/t/amd-wont-sleep-properly/41755 Link: https://community.frame.work/t/tracking-framework-amd-ryzen-7040-series-lid-wakeup-behavior-feedback/39128 Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Link: https://lore.kernel.org/r/20231212045006.97581-5-mario.limonciello@amd.com Reviewed-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
1 parent b614a4b commit a55bdad

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

drivers/platform/x86/amd/pmc/pmc-quirks.c

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,17 @@
1616

1717
struct quirk_entry {
1818
u32 s2idle_bug_mmio;
19+
bool spurious_8042;
1920
};
2021

2122
static struct quirk_entry quirk_s2idle_bug = {
2223
.s2idle_bug_mmio = 0xfed80380,
2324
};
2425

26+
static struct quirk_entry quirk_spurious_8042 = {
27+
.spurious_8042 = true,
28+
};
29+
2530
static const struct dmi_system_id fwbug_list[] = {
2631
{
2732
.ident = "L14 Gen2 AMD",
@@ -193,6 +198,16 @@ static const struct dmi_system_id fwbug_list[] = {
193198
DMI_MATCH(DMI_PRODUCT_NAME, "HP Laptop 15s-eq2xxx"),
194199
}
195200
},
201+
/* https://community.frame.work/t/tracking-framework-amd-ryzen-7040-series-lid-wakeup-behavior-feedback/39128 */
202+
{
203+
.ident = "Framework Laptop 13 (Phoenix)",
204+
.driver_data = &quirk_spurious_8042,
205+
.matches = {
206+
DMI_MATCH(DMI_SYS_VENDOR, "Framework"),
207+
DMI_MATCH(DMI_PRODUCT_NAME, "Laptop 13 (AMD Ryzen 7040Series)"),
208+
DMI_MATCH(DMI_BIOS_VERSION, "03.03"),
209+
}
210+
},
196211
{}
197212
};
198213

@@ -245,4 +260,6 @@ void amd_pmc_quirks_init(struct amd_pmc_dev *dev)
245260
if (dev->quirks->s2idle_bug_mmio)
246261
pr_info("Using s2idle quirk to avoid %s platform firmware bug\n",
247262
dmi_id->ident);
263+
if (dev->quirks->spurious_8042)
264+
dev->disable_8042_wakeup = true;
248265
}

0 commit comments

Comments
 (0)