Skip to content

Commit a4a79e0

Browse files
tmlindgregkh
authored andcommitted
serial: core: Revert port_id use
Guenter reports boot issues with duplicate sysfs entries for multiport drivers. Let's go back to using port->line for now to fix the regression. With this change, the serial core port device names are not correct for the hardware specific 8250 single port drivers, but that's a cosmetic issue for now. Fixes: d962de6 ("serial: core: Fix serial core port id to not use port->line") Reported-by: Guenter Roeck <groeck7@gmail.com> Signed-off-by: Tony Lindgren <tony@atomide.com> Tested-by: Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/20230806062052.47737-1-tony@atomide.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 3f29d9e commit a4a79e0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/tty/serial/serial_base_bus.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ struct serial_port_device *serial_base_port_add(struct uart_port *port,
151151
err = serial_base_device_init(port, &port_dev->dev,
152152
&ctrl_dev->dev, &serial_port_type,
153153
serial_base_port_release,
154-
port->ctrl_id, port->port_id);
154+
port->ctrl_id, port->line);
155155
if (err)
156156
goto err_put_device;
157157

0 commit comments

Comments
 (0)