Skip to content

Commit a493208

Browse files
fltoJassiBrar
authored andcommitted
mailbox: qcom-ipcc: fix incorrect num_chans counting
Breaking out early when a match is found leads to an incorrect num_chans value when more than one ipcc mailbox channel is used by the same device. Fixes: e9d50e4 ("mailbox: qcom-ipcc: Dynamic alloc for channel arrangement") Signed-off-by: Jonathan Marek <jonathan@marek.ca> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
1 parent e9803aa commit a493208

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/mailbox/qcom-ipcc.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,10 +227,8 @@ static int qcom_ipcc_setup_mbox(struct qcom_ipcc *ipcc,
227227
ret = of_parse_phandle_with_args(client_dn, "mboxes",
228228
"#mbox-cells", j, &curr_ph);
229229
of_node_put(curr_ph.np);
230-
if (!ret && curr_ph.np == controller_dn) {
230+
if (!ret && curr_ph.np == controller_dn)
231231
ipcc->num_chans++;
232-
break;
233-
}
234232
}
235233
}
236234

0 commit comments

Comments
 (0)