Skip to content

Commit a3fad2e

Browse files
Marco Paganigregkh
authored andcommitted
fpga: disable KUnit test suites when module support is enabled
The fpga core currently assumes that all manager, bridge, and region devices have a parent device associated with a driver that can be used to take the module's refcount. This behavior causes the fpga test suites to crash with a null-ptr-deref since parent fake devices do not have a driver. This patch disables all fpga KUnit test suites when loadable module support is enabled until the fpga core is fixed. Test suites can still be run using the KUnit default UML kernel. Signed-off-by: Marco Pagani <marpagan@redhat.com> Acked-by: Xu Yilun <yilun.xu@intel.com> Fixes: ccbc1c3 ("fpga: add an initial KUnit suite for the FPGA Manager") Link: https://lore.kernel.org/r/20231018163814.100803-1-marpagan@redhat.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 2382c1b commit a3fad2e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/fpga/tests/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
config FPGA_KUNIT_TESTS
2-
tristate "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS
3-
depends on FPGA && FPGA_REGION && FPGA_BRIDGE && KUNIT=y
2+
bool "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS
3+
depends on FPGA=y && FPGA_REGION=y && FPGA_BRIDGE=y && KUNIT=y && MODULES=n
44
default KUNIT_ALL_TESTS
55
help
66
This builds unit tests for the FPGA subsystem

0 commit comments

Comments
 (0)