Skip to content

Commit a3a7d16

Browse files
committed
Merge tag 'usb-6.8-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb
Pull USB / Thunderbolt fixes from Greg KH: "Here are two small fixes for 6.8-rc5: - thunderbolt to fix a reported issue on many platforms - dwc3 driver revert of a commit that caused problems in -rc1 Both of these changes have been in linux-next for over a week with no reported issues" * tag 'usb-6.8-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb: Revert "usb: dwc3: Support EBC feature of DWC_usb31" thunderbolt: Fix setting the CNS bit in ROUTER_CS_5
2 parents ac00b65 + 7d708c1 commit a3a7d16

File tree

6 files changed

+2
-12
lines changed

6 files changed

+2
-12
lines changed

drivers/thunderbolt/tb_regs.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ struct tb_regs_switch_header {
203203
#define ROUTER_CS_5_WOP BIT(1)
204204
#define ROUTER_CS_5_WOU BIT(2)
205205
#define ROUTER_CS_5_WOD BIT(3)
206-
#define ROUTER_CS_5_C3S BIT(23)
206+
#define ROUTER_CS_5_CNS BIT(23)
207207
#define ROUTER_CS_5_PTO BIT(24)
208208
#define ROUTER_CS_5_UTO BIT(25)
209209
#define ROUTER_CS_5_HCO BIT(26)

drivers/thunderbolt/usb4.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ int usb4_switch_setup(struct tb_switch *sw)
290290
}
291291

292292
/* TBT3 supported by the CM */
293-
val |= ROUTER_CS_5_C3S;
293+
val &= ~ROUTER_CS_5_CNS;
294294

295295
return tb_sw_write(sw, &val, TB_CFG_SWITCH, ROUTER_CS_5, 1);
296296
}

drivers/usb/dwc3/core.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,6 @@
376376
/* Global HWPARAMS4 Register */
377377
#define DWC3_GHWPARAMS4_HIBER_SCRATCHBUFS(n) (((n) & (0x0f << 13)) >> 13)
378378
#define DWC3_MAX_HIBER_SCRATCHBUFS 15
379-
#define DWC3_EXT_BUFF_CONTROL BIT(21)
380379

381380
/* Global HWPARAMS6 Register */
382381
#define DWC3_GHWPARAMS6_BCSUPPORT BIT(14)

drivers/usb/dwc3/gadget.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -673,12 +673,6 @@ static int dwc3_gadget_set_ep_config(struct dwc3_ep *dep, unsigned int action)
673673
params.param1 |= DWC3_DEPCFG_BINTERVAL_M1(bInterval_m1);
674674
}
675675

676-
if (dep->endpoint.fifo_mode) {
677-
if (!(dwc->hwparams.hwparams4 & DWC3_EXT_BUFF_CONTROL))
678-
return -EINVAL;
679-
params.param1 |= DWC3_DEPCFG_EBC_HWO_NOWB | DWC3_DEPCFG_USE_EBC;
680-
}
681-
682676
return dwc3_send_gadget_ep_cmd(dep, DWC3_DEPCMD_SETEPCONFIG, &params);
683677
}
684678

drivers/usb/dwc3/gadget.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ struct dwc3;
2626
#define DWC3_DEPCFG_XFER_NOT_READY_EN BIT(10)
2727
#define DWC3_DEPCFG_FIFO_ERROR_EN BIT(11)
2828
#define DWC3_DEPCFG_STREAM_EVENT_EN BIT(13)
29-
#define DWC3_DEPCFG_EBC_HWO_NOWB BIT(14)
30-
#define DWC3_DEPCFG_USE_EBC BIT(15)
3129
#define DWC3_DEPCFG_BINTERVAL_M1(n) (((n) & 0xff) << 16)
3230
#define DWC3_DEPCFG_STREAM_CAPABLE BIT(24)
3331
#define DWC3_DEPCFG_EP_NUMBER(n) (((n) & 0x1f) << 25)

include/linux/usb/gadget.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,6 @@ struct usb_ep {
236236
unsigned max_streams:16;
237237
unsigned mult:2;
238238
unsigned maxburst:5;
239-
unsigned fifo_mode:1;
240239
u8 address;
241240
const struct usb_endpoint_descriptor *desc;
242241
const struct usb_ss_ep_comp_descriptor *comp_desc;

0 commit comments

Comments
 (0)