Skip to content

Commit a39f5cc

Browse files
Christoph HellwigChandan Babu R
authored andcommitted
xfs: remove XFS_RTMIN/XFS_RTMAX
Use the kernel min/max helpers instead. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
1 parent 3abfe6c commit a39f5cc

File tree

3 files changed

+8
-13
lines changed

3 files changed

+8
-13
lines changed

fs/xfs/libxfs/xfs_format.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1156,12 +1156,6 @@ static inline bool xfs_dinode_has_large_extent_counts(
11561156
#define XFS_DFL_RTEXTSIZE (64 * 1024) /* 64kB */
11571157
#define XFS_MIN_RTEXTSIZE (4 * 1024) /* 4kB */
11581158

1159-
/*
1160-
* RT bit manipulation macros.
1161-
*/
1162-
#define XFS_RTMIN(a,b) ((a) < (b) ? (a) : (b))
1163-
#define XFS_RTMAX(a,b) ((a) > (b) ? (a) : (b))
1164-
11651159
/*
11661160
* Dquot and dquot block format definitions
11671161
*/

fs/xfs/libxfs/xfs_rtbitmap.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ xfs_rtfind_back(
184184
* Calculate first (leftmost) bit number to look at,
185185
* and mask for all the relevant bits in this word.
186186
*/
187-
firstbit = XFS_RTMAX((xfs_srtblock_t)(bit - len + 1), 0);
187+
firstbit = max_t(xfs_srtblock_t, bit - len + 1, 0);
188188
mask = (((xfs_rtword_t)1 << (bit - firstbit + 1)) - 1) <<
189189
firstbit;
190190
/*
@@ -338,7 +338,7 @@ xfs_rtfind_forw(
338338
* Calculate last (rightmost) bit number to look at,
339339
* and mask for all the relevant bits in this word.
340340
*/
341-
lastbit = XFS_RTMIN(bit + len, XFS_NBWORD);
341+
lastbit = min(bit + len, XFS_NBWORD);
342342
mask = (((xfs_rtword_t)1 << (lastbit - bit)) - 1) << bit;
343343
/*
344344
* Calculate the difference between the value there
@@ -573,7 +573,7 @@ xfs_rtmodify_range(
573573
/*
574574
* Compute first bit not changed and mask of relevant bits.
575575
*/
576-
lastbit = XFS_RTMIN(bit + len, XFS_NBWORD);
576+
lastbit = min(bit + len, XFS_NBWORD);
577577
mask = (((xfs_rtword_t)1 << (lastbit - bit)) - 1) << bit;
578578
/*
579579
* Set/clear the active bits.
@@ -787,7 +787,7 @@ xfs_rtcheck_range(
787787
/*
788788
* Compute first bit not examined.
789789
*/
790-
lastbit = XFS_RTMIN(bit + len, XFS_NBWORD);
790+
lastbit = min(bit + len, XFS_NBWORD);
791791
/*
792792
* Mask of relevant bits.
793793
*/

fs/xfs/xfs_rtalloc.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -638,9 +638,10 @@ xfs_rtallocate_extent_size(
638638
* for this summary level.
639639
*/
640640
for (l = xfs_highbit32(maxlen); l >= xfs_highbit32(minlen); l--) {
641-
error = xfs_rtalloc_sumlevel(args, l, XFS_RTMAX(minlen, 1 << l),
642-
XFS_RTMIN(maxlen, (1 << (l + 1)) - 1), prod,
643-
len, rtx);
641+
error = xfs_rtalloc_sumlevel(args, l,
642+
max_t(xfs_rtxlen_t, minlen, 1 << l),
643+
min_t(xfs_rtxlen_t, maxlen, (1 << (l + 1)) - 1),
644+
prod, len, rtx);
644645
if (error != -ENOSPC)
645646
return error;
646647
}

0 commit comments

Comments
 (0)