Skip to content

Commit a370b2d

Browse files
tlebbebarino
authored andcommitted
dt-bindings: soc: mobileye: set #clock-cells = <1> for all compatibles
Some compatibles expose a single clock. For those, we used to let them using `#clock-cells = <0>` (ie <&olb> reference rather than <&olb 0>). Switch away from that: enforce a cell for all compatibles. This is more straight forward, and avoids devicetree changes whenever a compatible goes from exposing a single clock to multiple ones. Also, dt-bindings get simpler. *This is an ABI break*. Change it while EyeQ5 platform support is at its infancy, without any user. More clocks might hide in each OLB as some registers are still unknown. Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> Link: https://lore.kernel.org/r/20241106-mbly-clk-v2-1-84cfefb3f485@bootlin.com Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Rob Herring (Arm) <robh@kernel.org> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 25d9049 commit a370b2d

File tree

1 file changed

+1
-23
lines changed

1 file changed

+1
-23
lines changed

Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,7 @@ properties:
4141
enum: [ 1, 2 ]
4242

4343
'#clock-cells':
44-
description:
45-
Cell is clock index. Optional if compatible has a single clock.
46-
enum: [ 0, 1 ]
44+
const: 1
4745

4846
clocks:
4947
maxItems: 1
@@ -312,26 +310,6 @@ allOf:
312310
properties:
313311
'#reset-cells': false
314312

315-
# Compatibles exposing a single clock.
316-
- if:
317-
properties:
318-
compatible:
319-
contains:
320-
enum:
321-
- mobileye,eyeq6h-central-olb
322-
- mobileye,eyeq6h-east-olb
323-
- mobileye,eyeq6h-west-olb
324-
- mobileye,eyeq6h-ddr0-olb
325-
- mobileye,eyeq6h-ddr1-olb
326-
then:
327-
properties:
328-
'#clock-cells':
329-
const: 0
330-
else:
331-
properties:
332-
'#clock-cells':
333-
const: 1
334-
335313
# Only EyeQ5 has pinctrl in OLB.
336314
- if:
337315
not:

0 commit comments

Comments
 (0)