Skip to content

Commit a2118ce

Browse files
raagjadavandy-shev
authored andcommitted
pinctrl: cherryview: reuse common functions from pinctrl-intel
Reuse common functions from pinctrl-intel driver. Signed-off-by: Raag Jadav <raag.jadav@intel.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> Link: https://lore.kernel.org/r/20230814060311.15945-4-raag.jadav@intel.com Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
1 parent 4d01688 commit a2118ce

File tree

1 file changed

+9
-60
lines changed

1 file changed

+9
-60
lines changed

drivers/pinctrl/intel/pinctrl-cherryview.c

Lines changed: 9 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -617,31 +617,6 @@ static bool chv_pad_locked(struct intel_pinctrl *pctrl, unsigned int offset)
617617
return chv_readl(pctrl, offset, CHV_PADCTRL1) & CHV_PADCTRL1_CFGLOCK;
618618
}
619619

620-
static int chv_get_groups_count(struct pinctrl_dev *pctldev)
621-
{
622-
struct intel_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
623-
624-
return pctrl->soc->ngroups;
625-
}
626-
627-
static const char *chv_get_group_name(struct pinctrl_dev *pctldev,
628-
unsigned int group)
629-
{
630-
struct intel_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
631-
632-
return pctrl->soc->groups[group].grp.name;
633-
}
634-
635-
static int chv_get_group_pins(struct pinctrl_dev *pctldev, unsigned int group,
636-
const unsigned int **pins, unsigned int *npins)
637-
{
638-
struct intel_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
639-
640-
*pins = pctrl->soc->groups[group].grp.pins;
641-
*npins = pctrl->soc->groups[group].grp.npins;
642-
return 0;
643-
}
644-
645620
static void chv_pin_dbg_show(struct pinctrl_dev *pctldev, struct seq_file *s,
646621
unsigned int offset)
647622
{
@@ -676,39 +651,12 @@ static void chv_pin_dbg_show(struct pinctrl_dev *pctldev, struct seq_file *s,
676651
}
677652

678653
static const struct pinctrl_ops chv_pinctrl_ops = {
679-
.get_groups_count = chv_get_groups_count,
680-
.get_group_name = chv_get_group_name,
681-
.get_group_pins = chv_get_group_pins,
654+
.get_groups_count = intel_get_groups_count,
655+
.get_group_name = intel_get_group_name,
656+
.get_group_pins = intel_get_group_pins,
682657
.pin_dbg_show = chv_pin_dbg_show,
683658
};
684659

685-
static int chv_get_functions_count(struct pinctrl_dev *pctldev)
686-
{
687-
struct intel_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
688-
689-
return pctrl->soc->nfunctions;
690-
}
691-
692-
static const char *chv_get_function_name(struct pinctrl_dev *pctldev,
693-
unsigned int function)
694-
{
695-
struct intel_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
696-
697-
return pctrl->soc->functions[function].func.name;
698-
}
699-
700-
static int chv_get_function_groups(struct pinctrl_dev *pctldev,
701-
unsigned int function,
702-
const char * const **groups,
703-
unsigned int * const ngroups)
704-
{
705-
struct intel_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
706-
707-
*groups = pctrl->soc->functions[function].func.groups;
708-
*ngroups = pctrl->soc->functions[function].func.ngroups;
709-
return 0;
710-
}
711-
712660
static int chv_pinmux_set_mux(struct pinctrl_dev *pctldev,
713661
unsigned int function, unsigned int group)
714662
{
@@ -884,9 +832,9 @@ static int chv_gpio_set_direction(struct pinctrl_dev *pctldev,
884832
}
885833

886834
static const struct pinmux_ops chv_pinmux_ops = {
887-
.get_functions_count = chv_get_functions_count,
888-
.get_function_name = chv_get_function_name,
889-
.get_function_groups = chv_get_function_groups,
835+
.get_functions_count = intel_get_functions_count,
836+
.get_function_name = intel_get_function_name,
837+
.get_function_groups = intel_get_function_groups,
890838
.set_mux = chv_pinmux_set_mux,
891839
.gpio_request_enable = chv_gpio_request_enable,
892840
.gpio_disable_free = chv_gpio_disable_free,
@@ -1118,7 +1066,7 @@ static int chv_config_group_get(struct pinctrl_dev *pctldev,
11181066
unsigned int npins;
11191067
int ret;
11201068

1121-
ret = chv_get_group_pins(pctldev, group, &pins, &npins);
1069+
ret = intel_get_group_pins(pctldev, group, &pins, &npins);
11221070
if (ret)
11231071
return ret;
11241072

@@ -1137,7 +1085,7 @@ static int chv_config_group_set(struct pinctrl_dev *pctldev,
11371085
unsigned int npins;
11381086
int i, ret;
11391087

1140-
ret = chv_get_group_pins(pctldev, group, &pins, &npins);
1088+
ret = intel_get_group_pins(pctldev, group, &pins, &npins);
11411089
if (ret)
11421090
return ret;
11431091

@@ -1915,3 +1863,4 @@ module_exit(chv_pinctrl_exit);
19151863
MODULE_AUTHOR("Mika Westerberg <mika.westerberg@linux.intel.com>");
19161864
MODULE_DESCRIPTION("Intel Cherryview/Braswell pinctrl driver");
19171865
MODULE_LICENSE("GPL v2");
1866+
MODULE_IMPORT_NS(PINCTRL_INTEL);

0 commit comments

Comments
 (0)