Skip to content

Commit a0c313d

Browse files
Uwe Kleine-KönigJassiBrar
authored andcommitted
mailbox: imx: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
1 parent 74701ff commit a0c313d

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/mailbox/imx-mailbox.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -903,13 +903,11 @@ static int imx_mu_probe(struct platform_device *pdev)
903903
return ret;
904904
}
905905

906-
static int imx_mu_remove(struct platform_device *pdev)
906+
static void imx_mu_remove(struct platform_device *pdev)
907907
{
908908
struct imx_mu_priv *priv = platform_get_drvdata(pdev);
909909

910910
pm_runtime_disable(priv->dev);
911-
912-
return 0;
913911
}
914912

915913
static const struct imx_mu_dcfg imx_mu_cfg_imx6sx = {
@@ -1070,7 +1068,7 @@ static const struct dev_pm_ops imx_mu_pm_ops = {
10701068

10711069
static struct platform_driver imx_mu_driver = {
10721070
.probe = imx_mu_probe,
1073-
.remove = imx_mu_remove,
1071+
.remove_new = imx_mu_remove,
10741072
.driver = {
10751073
.name = "imx_mu",
10761074
.of_match_table = imx_mu_dt_ids,

0 commit comments

Comments
 (0)