Skip to content

Commit 9fb266d

Browse files
pgreenwaanguy11
authored andcommitted
ice: fix Get link status data length
Get link status version 2 (opcode 0x0607) is returning an error because FW expects a data length of 56 bytes, and this is causing the driver to fail probe. Update the get link status version 2 data length to 56 bytes by adding 5 byte reserved5 field to the end of struct ice_aqc_get_link_status_data and passing it as parameter to offsetofend() to the fix error. Fixes: 2777d24 ("ice: Add ice_get_link_status_datalen") Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
1 parent 371e576 commit 9fb266d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/net/ethernet/intel/ice/ice_adminq_cmd.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1359,8 +1359,9 @@ struct ice_aqc_get_link_status_data {
13591359
u8 lp_flowcontrol;
13601360
#define ICE_AQ_LINK_LP_PAUSE_ADV BIT(0)
13611361
#define ICE_AQ_LINK_LP_ASM_DIR_ADV BIT(1)
1362+
u8 reserved5[5];
13621363
#define ICE_AQC_LS_DATA_SIZE_V2 \
1363-
offsetofend(struct ice_aqc_get_link_status_data, lp_flowcontrol)
1364+
offsetofend(struct ice_aqc_get_link_status_data, reserved5)
13641365
} __packed;
13651366

13661367
/* Set event mask command (direct 0x0613) */

0 commit comments

Comments
 (0)