Skip to content

Commit 9bf2e91

Browse files
Sarannya Sdavem330
authored andcommitted
net: qrtr: ns: Return 0 if server port is not present
When a 'DEL_CLIENT' message is received from the remote, the corresponding server port gets deleted. A DEL_SERVER message is then announced for this server. As part of handling the subsequent DEL_SERVER message, the name- server attempts to delete the server port which results in a '-ENOENT' error. The return value from server_del() is then propagated back to qrtr_ns_worker, causing excessive error prints. To address this, return 0 from control_cmd_del_server() without checking the return value of server_del(), since the above scenario is not an error case and hence server_del() doesn't have any other error return value. Signed-off-by: Sarannya Sasikumar <quic_sarannya@quicinc.com> Reviewed-by: Simon Horman <horms@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 82585d5 commit 9bf2e91

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

net/qrtr/ns.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,9 @@ static int ctrl_cmd_del_server(struct sockaddr_qrtr *from,
512512
if (!node)
513513
return -ENOENT;
514514

515-
return server_del(node, port, true);
515+
server_del(node, port, true);
516+
517+
return 0;
516518
}
517519

518520
static int ctrl_cmd_new_lookup(struct sockaddr_qrtr *from,

0 commit comments

Comments
 (0)