Skip to content

Commit 9b37feb

Browse files
committed
tracing: Have current_trace inc the trace array ref count
The current_trace updates the trace array tracer. For an instance, if the file is opened and the instance is deleted, reading or writing to the file will cause a use after free. Up the ref count of the trace array when current_trace is opened. Link: https://lkml.kernel.org/r/20230907024803.877687227@goodmis.org Link: https://lore.kernel.org/all/1cb3aee2-19af-c472-e265-05176fe9bd84@huawei.com/ Cc: stable@vger.kernel.org Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Zheng Yejian <zhengyejian1@huawei.com> Fixes: 8530dec ("tracing: Add tracing_check_open_get_tr()") Tested-by: Linux Kernel Functional Testing <lkft@linaro.org> Tested-by: Naresh Kamboju <naresh.kamboju@linaro.org> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent 7d660c9 commit 9b37feb

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

kernel/trace/trace.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7791,10 +7791,11 @@ static const struct file_operations tracing_max_lat_fops = {
77917791
#endif
77927792

77937793
static const struct file_operations set_tracer_fops = {
7794-
.open = tracing_open_generic,
7794+
.open = tracing_open_generic_tr,
77957795
.read = tracing_set_trace_read,
77967796
.write = tracing_set_trace_write,
77977797
.llseek = generic_file_llseek,
7798+
.release = tracing_release_generic_tr,
77987799
};
77997800

78007801
static const struct file_operations tracing_pipe_fops = {

0 commit comments

Comments
 (0)