Skip to content

Commit 9ac3eba

Browse files
Erick Archervireshk
authored andcommitted
Documentation: power: Use kcalloc() instead of kzalloc()
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors. So, in the example code use the purpose specific kcalloc() function instead of the argument size * count in the kzalloc() function. At the same time, modify the translations accordingly. Signed-off-by: Erick Archer <erick.archer@gmx.com> Reviewed-by: Hu Haowen <2023002089@link.tyut.edu.cn> Reviewed-by: Yanteng Si <siyanteng@loongson.cn> Reviewed-by: Hu Haowen <2023002089@link.tyut.edu.cn> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
1 parent 788715b commit 9ac3eba

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Documentation/power/opp.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ dev_pm_opp_get_opp_count
305305
{
306306
/* Do things */
307307
num_available = dev_pm_opp_get_opp_count(dev);
308-
speeds = kzalloc(sizeof(u32) * num_available, GFP_KERNEL);
308+
speeds = kcalloc(num_available, sizeof(u32), GFP_KERNEL);
309309
/* populate the table in increasing order */
310310
freq = 0;
311311
while (!IS_ERR(opp = dev_pm_opp_find_freq_ceil(dev, &freq))) {

Documentation/translations/zh_CN/power/opp.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ dev_pm_opp_get_opp_count
274274
{
275275
/* 做一些事情 */
276276
num_available = dev_pm_opp_get_opp_count(dev);
277-
speeds = kzalloc(sizeof(u32) * num_available, GFP_KERNEL);
277+
speeds = kcalloc(num_available, sizeof(u32), GFP_KERNEL);
278278
/* 按升序填充表 */
279279
freq = 0;
280280
while (!IS_ERR(opp = dev_pm_opp_find_freq_ceil(dev, &freq))) {

0 commit comments

Comments
 (0)