Skip to content

Commit 9a41358

Browse files
GustavoARSilvaandersson
authored andcommitted
hwspinlock: sprd: Use struct_size() helper in devm_kzalloc()
Make use of the struct_size() helper instead of an open-coded version, in order to avoid any potential type mistakes or integer overflows that, in the worst scenario, could lead to heap overflows. Also, address the following sparse warnings: drivers/hwspinlock/sprd_hwspinlock.c:96:36: warning: using sizeof on a flexible structure Link: KSPP#174 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Reviewed-by: Baolin Wang <baolin.wang7@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Link: https://lore.kernel.org/r/20220125225723.GA78256@embeddedor
1 parent 3e5f1ff commit 9a41358

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/hwspinlock/sprd_hwspinlock.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,7 @@ static int sprd_hwspinlock_probe(struct platform_device *pdev)
9393
return -ENODEV;
9494

9595
sprd_hwlock = devm_kzalloc(&pdev->dev,
96-
sizeof(struct sprd_hwspinlock_dev) +
97-
SPRD_HWLOCKS_NUM * sizeof(*lock),
96+
struct_size(sprd_hwlock, bank.lock, SPRD_HWLOCKS_NUM),
9897
GFP_KERNEL);
9998
if (!sprd_hwlock)
10099
return -ENOMEM;

0 commit comments

Comments
 (0)