Skip to content

Commit 9a046c1

Browse files
arndbdtor
authored andcommitted
Input: stmpe-ts - use module alias instead of device table
When compile tested with W=1 on x86_64 with driver as built-in: stmpe-ts.c:371:34: error: unused variable 'stmpe_ts_ids' [-Werror,-Wunused-const-variable] Ideally this would be referenced from the platform_driver, but since the compatible string is already matched by the mfd driver for its parent device, that would break probing. In this case, the of_device_id table just serves as a module alias for loading the driver, while the device itself is probed using the platform device name. Remove the table and instead use a module alias that reflects how the driver is actually probed. Link: https://lore.kernel.org/lkml/20240403080702.3509288-8-arnd@kernel.org/ Link: https://lore.kernel.org/lkml/181dbdb8-c050-4966-8cb4-2f39495ff3f9@app.fastmail.com/ Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20250409122314.2848028-3-arnd@kernel.org Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent c6cb8bf commit 9a046c1

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

drivers/input/touchscreen/stmpe-ts.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -366,12 +366,7 @@ static struct platform_driver stmpe_ts_driver = {
366366
};
367367
module_platform_driver(stmpe_ts_driver);
368368

369-
static const struct of_device_id stmpe_ts_ids[] = {
370-
{ .compatible = "st,stmpe-ts", },
371-
{ },
372-
};
373-
MODULE_DEVICE_TABLE(of, stmpe_ts_ids);
374-
369+
MODULE_ALIAS("platform:stmpe-ts");
375370
MODULE_AUTHOR("Luotao Fu <l.fu@pengutronix.de>");
376371
MODULE_DESCRIPTION("STMPEXXX touchscreen driver");
377372
MODULE_LICENSE("GPL");

0 commit comments

Comments
 (0)