Skip to content

Commit 9944d20

Browse files
dTenebraedavem330
authored andcommitted
broadcom: b44: Use b44_writephy() return value
Return result of b44_writephy() instead of zero to deal with possible error. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru> Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent a552bfa commit 9944d20

File tree

1 file changed

+3
-5
lines changed
  • drivers/net/ethernet/broadcom

1 file changed

+3
-5
lines changed

drivers/net/ethernet/broadcom/b44.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1793,11 +1793,9 @@ static int b44_nway_reset(struct net_device *dev)
17931793
b44_readphy(bp, MII_BMCR, &bmcr);
17941794
b44_readphy(bp, MII_BMCR, &bmcr);
17951795
r = -EINVAL;
1796-
if (bmcr & BMCR_ANENABLE) {
1797-
b44_writephy(bp, MII_BMCR,
1798-
bmcr | BMCR_ANRESTART);
1799-
r = 0;
1800-
}
1796+
if (bmcr & BMCR_ANENABLE)
1797+
r = b44_writephy(bp, MII_BMCR,
1798+
bmcr | BMCR_ANRESTART);
18011799
spin_unlock_irq(&bp->lock);
18021800

18031801
return r;

0 commit comments

Comments
 (0)